fix(ci): green CI + GHA action bumps (supersedes Dependabot #1/#2/#3) #7

Merged
flndrn-dev merged 4 commits from fix/ci-green-and-gha-bumps into main 2026-04-24 21:20:01 +02:00
flndrn-dev commented 2026-04-24 21:00:25 +02:00 (Migrated from github.com)

Summary

CI on main was red on every PR (including the three Dependabot bumps for actions/checkout, actions/setup-node, pnpm/action-setup). Two pre-existing bugs were causing the lint and test jobs to fail. This PR fixes both root causes and bundles in the v4 → v6 GHA bumps the Dependabot PRs were proposing — so we land one consolidated fix instead of merging three rebased Dependabot PRs.

What's in here (3 commits)

  1. chore(ci): bump actions/checkout, setup-node, pnpm/action-setup v4 → v6 — supersedes Dependabot #1 / #2 / #3. We pin our pnpm and node versions inline (PNPM_VERSION: 9.12.0, NODE_VERSION: 20), so the action major bumps are no-ops for our setup.

  2. chore: add prettier-plugin-tailwindcss + reformat codebase.prettierrc referenced prettier-plugin-tailwindcss but the plugin was never installed at the root, so pnpm format:check errored with Cannot find package 'prettier-plugin-tailwindcss' imported from /home/runner/work/briven/briven/noop.js. Added the plugin to root devDeps and ran pnpm format once to bring 105 files in line with our Prettier config (mostly Tailwind class sorting + paragraph wrapping).

  3. test(cli): add smoke test + use tsx for test runner@briven/cli's test script was node --test src/**/*.test.ts, which exits 1 when the glob matches nothing AND can't load TS files anyway. Switched to tsx --test "src/**/*.test.ts" (matching @briven/schema) and added a 3-case smoke test that exercises run(['--help']) and unknown-command paths.

Test plan

  • pnpm format:check — green locally
  • pnpm lint — green locally (14 tasks pass)
  • pnpm typecheck — green locally (15 tasks pass)
  • pnpm --filter @briven/cli test — green (3/3 tests pass)
  • CI lint/format/typecheck/test/build/audit jobs all green on this PR
  • After merge: close Dependabot #1, #2, #3 with a comment pointing here

🤖 Generated with Claude Code

## Summary CI on `main` was red on every PR (including the three Dependabot bumps for `actions/checkout`, `actions/setup-node`, `pnpm/action-setup`). Two pre-existing bugs were causing the `lint` and `test` jobs to fail. This PR fixes both root causes and bundles in the v4 → v6 GHA bumps the Dependabot PRs were proposing — so we land one consolidated fix instead of merging three rebased Dependabot PRs. ## What's in here (3 commits) 1. **`chore(ci): bump actions/checkout, setup-node, pnpm/action-setup v4 → v6`** — supersedes Dependabot #1 / #2 / #3. We pin our pnpm and node versions inline (`PNPM_VERSION: 9.12.0`, `NODE_VERSION: 20`), so the action major bumps are no-ops for our setup. 2. **`chore: add prettier-plugin-tailwindcss + reformat codebase`** — `.prettierrc` referenced `prettier-plugin-tailwindcss` but the plugin was never installed at the root, so `pnpm format:check` errored with `Cannot find package 'prettier-plugin-tailwindcss' imported from /home/runner/work/briven/briven/noop.js`. Added the plugin to root devDeps and ran `pnpm format` once to bring 105 files in line with our Prettier config (mostly Tailwind class sorting + paragraph wrapping). 3. **`test(cli): add smoke test + use tsx for test runner`** — `@briven/cli`'s `test` script was `node --test src/**/*.test.ts`, which exits 1 when the glob matches nothing AND can't load TS files anyway. Switched to `tsx --test "src/**/*.test.ts"` (matching `@briven/schema`) and added a 3-case smoke test that exercises `run(['--help'])` and unknown-command paths. ## Test plan - [x] `pnpm format:check` — green locally - [x] `pnpm lint` — green locally (14 tasks pass) - [x] `pnpm typecheck` — green locally (15 tasks pass) - [x] `pnpm --filter @briven/cli test` — green (3/3 tests pass) - [ ] CI lint/format/typecheck/test/build/audit jobs all green on this PR - [ ] After merge: close Dependabot #1, #2, #3 with a comment pointing here 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No description provided.