Add a 'make verify' target that lints scripts/ + shellchecks the migration script #5

New issue

Open

opened 2026-05-08 20:40:09 +02:00 by flndrn · 0 comments

flndrn commented

2026-05-08 20:40:09 +02:00

Owner

Why

The migration script is the critical path of §6.3 and bash 3.2-compatible — easy to break with a careless edit. CI hasn't been wired yet; until it is, a local make verify would catch regressions before push.

Scope

Add a top-level Makefile with targets:

make verify — runs all of below in sequence
make lint-shell — shellcheck scripts/*.sh
make check-bash — runs each script with bash -n (syntax-only) under both bash 3.2 (if installed) and current bash
make check-docs — verifies links in *.md files don't 404 (use lychee or markdown-link-check)

Acceptance criteria

Makefile exists at repo root.
make verify runs clean against current state of main.
CI workflow (.forgejo/workflows/verify.yml) added that calls make verify on every PR.
CONTRIBUTING.md updated to mention make verify as the pre-PR check.

Pointers

Migration script: scripts/migrate-github-to-konnos.sh
Upstream Forgejo Actions runs via Gitea Actions runner — works the same way.

Friendly note: this is a slightly larger one. Pair it with one of the other good-first-issues if you want to start small first.

## Why The migration script is the critical path of `§6.3` and bash 3.2-compatible — easy to break with a careless edit. CI hasn't been wired yet; until it is, a local `make verify` would catch regressions before push. ## Scope Add a top-level `Makefile` with targets: - `make verify` — runs all of below in sequence - `make lint-shell` — `shellcheck scripts/*.sh` - `make check-bash` — runs each script with `bash -n` (syntax-only) under both bash 3.2 (if installed) and current bash - `make check-docs` — verifies links in `*.md` files don't 404 (use `lychee` or `markdown-link-check`) ## Acceptance criteria - [ ] `Makefile` exists at repo root. - [ ] `make verify` runs clean against current state of `main`. - [ ] CI workflow (`.forgejo/workflows/verify.yml`) added that calls `make verify` on every PR. - [ ] `CONTRIBUTING.md` updated to mention `make verify` as the pre-PR check. ## Pointers - Migration script: `scripts/migrate-github-to-konnos.sh` - Upstream Forgejo Actions runs via Gitea Actions runner — works the same way. Friendly note: this is a slightly larger one. Pair it with one of the other good-first-issues if you want to start small first.